Discussion:
[Buildroot] [PATCH] br2-external: make it available to post-{build, image} scripts
Yann E. MORIN
2015-02-07 18:28:21 UTC
Permalink
Currently, BR2_EXTERNAL is not always exported to sub-processes that we
spawn, like post-build or post-image scripts. This all depends on how
the user passes BR2_EXTERNAL; consider the following:

- make BR2_EXTERNAL=/path/to/br2-ext
- BR2_EXTERNAL=/path/to/br2-ext make

In the first case, it is just a make variable, not an environment
variable, and thus not exported, while in the second case it is an
environment variable and gets exported to all sub-processes make may
spawn.

Explicitly export it using EXTRA_ENV.

Reported-by: Julian Scheel <***@jusst.de>
Signed-off-by: "Yann E. MORIN" <***@free.fr>
Cc: Julian Scheel <***@jusst.de>
---
package/Makefile.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/Makefile.in b/package/Makefile.in
index 70529f8..803b162 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -326,7 +326,8 @@ HOST_MAKE_ENV = \
EXTRA_ENV = \
PATH=$(BR_PATH) \
BR2_DL_DIR=$(BR2_DL_DIR) \
- BUILD_DIR=$(BUILD_DIR)
+ BUILD_DIR=$(BUILD_DIR) \
+ BR2_EXTERNAL=$(BR2_EXTERNAL)

################################################################################
# settings we need to pass to configure
--
1.9.1
Peter Korsgaard
2015-02-07 19:46:17 UTC
Permalink
Post by Yann E. MORIN
Currently, BR2_EXTERNAL is not always exported to sub-processes that we
spawn, like post-build or post-image scripts. This all depends on how
- make BR2_EXTERNAL=/path/to/br2-ext
- BR2_EXTERNAL=/path/to/br2-ext make
In the first case, it is just a make variable, not an environment
variable, and thus not exported, while in the second case it is an
environment variable and gets exported to all sub-processes make may
spawn.
Explicitly export it using EXTRA_ENV.
Committed, thanks.
--
Bye, Peter Korsgaard
Loading...