Discussion:
[PATCH 1/1] package/weston: bump to version 5.0.0
(too old to reply)
James Hilliard
2018-12-10 11:49:16 UTC
Permalink
The patch I removed was just a backport of this
https://github.com/wayland-project/weston/commit/029583e56e6eaad4139e39b4cf908158ab8cc91a
which is now included in 5.0.0.
Hi James,
---
...tor-fix-compilation-against-FreeRDP-2.0.0.patch | 181 ---------------------
package/weston/weston.hash | 10 +-
package/weston/weston.mk | 2 +-
3 files changed, 6 insertions(+), 187 deletions(-)
delete mode 100644 package/weston/0002-rdp-compositor-fix-compilation-against-FreeRDP-2.0.0.patch
As you remove the configure.ac patch, is autoreconf still needed? If it
is, please update the autoreconf comment.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
Baruch Siach
2018-12-10 11:55:39 UTC
Permalink
Hi James,
Post by James Hilliard
The patch I removed was just a backport of this
https://github.com/wayland-project/weston/commit/029583e56e6eaad4139e39b4cf908158ab8cc91a
which is now included in 5.0.0.
This is great (and should appear in the commit log). But besides that
there are these lines in weston.mk:

# 0002-rdp-compositor-fix-compilation-against-FreeRDP-2.0.0.patch
WESTON_AUTORECONF = YES

The comment is clearly wrong once you remove the patch. Moreover,
autoreconf itself might not be needed anymore. In that case you should
remove it.

baruch
Post by James Hilliard
---
...tor-fix-compilation-against-FreeRDP-2.0.0.patch | 181 ---------------------
package/weston/weston.hash | 10 +-
package/weston/weston.mk | 2 +-
3 files changed, 6 insertions(+), 187 deletions(-)
delete mode 100644 package/weston/0002-rdp-compositor-fix-compilation-against-FreeRDP-2.0.0.patch
As you remove the configure.ac patch, is autoreconf still needed? If it
is, please update the autoreconf comment.
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- ***@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
James Hilliard
2018-12-10 12:05:09 UTC
Permalink
Hi James,
Post by James Hilliard
The patch I removed was just a backport of this
https://github.com/wayland-project/weston/commit/029583e56e6eaad4139e39b4cf908158ab8cc91a
which is now included in 5.0.0.
This is great (and should appear in the commit log). But besides that
# 0002-rdp-compositor-fix-compilation-against-FreeRDP-2.0.0.patch
WESTON_AUTORECONF = YES
The comment is clearly wrong once you remove the patch. Moreover,
autoreconf itself might not be needed anymore. In that case you should
remove it.
yeah, seems to build fine without that, removed it in my v2
baruch
Post by James Hilliard
---
...tor-fix-compilation-against-FreeRDP-2.0.0.patch | 181 ---------------------
package/weston/weston.hash | 10 +-
package/weston/weston.mk | 2 +-
3 files changed, 6 insertions(+), 187 deletions(-)
delete mode 100644 package/weston/0002-rdp-compositor-fix-compilation-against-FreeRDP-2.0.0.patch
As you remove the configure.ac patch, is autoreconf still needed? If it
is, please update the autoreconf comment.
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
Loading...