Discussion:
[PATCH] configs/chiliboard: remove explicit getty port
(too old to reply)
Marcin Niestroj
2018-11-21 21:01:42 UTC
Permalink
Using default value (console) works well, so there is no reason to set
tty explicitly. Additionally after selecting newer kernels (tested
with 4.19 and 4.20-rc3) ttyO0 no longer works due to missing device
node.

Signed-off-by: Marcin Niestroj <***@grinn-global.com>
---
configs/grinn_chiliboard_defconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/configs/grinn_chiliboard_defconfig b/configs/grinn_chiliboard_defconfig
index 81d7bae911..84f24e1cc4 100644
--- a/configs/grinn_chiliboard_defconfig
+++ b/configs/grinn_chiliboard_defconfig
@@ -1,7 +1,6 @@
BR2_arm=y
BR2_cortex_a8=y
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_16=y
-BR2_TARGET_GENERIC_GETTY_PORT="ttyO0"
BR2_SYSTEM_DHCP="eth0"
BR2_ROOTFS_POST_IMAGE_SCRIPT="board/grinn/chiliboard/post-image.sh"
BR2_LINUX_KERNEL=y
--
2.19.1
Arnout Vandecappelle
2018-11-22 22:36:36 UTC
Permalink
Post by Marcin Niestroj
Using default value (console) works well, so there is no reason to set
tty explicitly. Additionally after selecting newer kernels (tested
with 4.19 and 4.20-rc3) ttyO0 no longer works due to missing device
node.
Actually, does it still work with the 4.16 kernel? IIRC the ttyO were replaced
by the standard ttyS ages ago (like, 3.18 or something like that). If it doesn't
work with the 4.16 kernel, it should be applied to master.

Anyway,

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <***@mind.be>

Regards,
Arnout
Post by Marcin Niestroj
---
configs/grinn_chiliboard_defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/configs/grinn_chiliboard_defconfig b/configs/grinn_chiliboard_defconfig
index 81d7bae911..84f24e1cc4 100644
--- a/configs/grinn_chiliboard_defconfig
+++ b/configs/grinn_chiliboard_defconfig
@@ -1,7 +1,6 @@
BR2_arm=y
BR2_cortex_a8=y
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_16=y
-BR2_TARGET_GENERIC_GETTY_PORT="ttyO0"
BR2_SYSTEM_DHCP="eth0"
BR2_ROOTFS_POST_IMAGE_SCRIPT="board/grinn/chiliboard/post-image.sh"
BR2_LINUX_KERNEL=y
Marcin Niestrój
2018-11-23 10:12:57 UTC
Permalink
Hi Arnout,
Post by Arnout Vandecappelle
Post by Marcin Niestroj
Using default value (console) works well, so there is no reason to set
tty explicitly. Additionally after selecting newer kernels (tested
with 4.19 and 4.20-rc3) ttyO0 no longer works due to missing device
node.
Actually, does it still work with the 4.16 kernel? IIRC the ttyO were replaced
by the standard ttyS ages ago (like, 3.18 or something like that). If it doesn't
work with the 4.16 kernel, it should be applied to master.
Yes, it still works with 4.16. There are /dev/ttyS[0-5] and /dev/ttyO0
nodes. In case of 4.19 and 4.20 there is no /dev/ttyO0 anymore, but I
did not get into the exact reason what changed. I just checked how other
boards configure getty in Buildroot and it turns out most of them leave
the default value.
Post by Arnout Vandecappelle
Anyway,
Thanks!

Regards,
Marcin
Post by Arnout Vandecappelle
Regards,
Arnout
Post by Marcin Niestroj
---
configs/grinn_chiliboard_defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/configs/grinn_chiliboard_defconfig b/configs/grinn_chiliboard_defconfig
index 81d7bae911..84f24e1cc4 100644
--- a/configs/grinn_chiliboard_defconfig
+++ b/configs/grinn_chiliboard_defconfig
@@ -1,7 +1,6 @@
BR2_arm=y
BR2_cortex_a8=y
BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_16=y
-BR2_TARGET_GENERIC_GETTY_PORT="ttyO0"
BR2_SYSTEM_DHCP="eth0"
BR2_ROOTFS_POST_IMAGE_SCRIPT="board/grinn/chiliboard/post-image.sh"
BR2_LINUX_KERNEL=y
Peter Korsgaard
2018-12-09 20:55:05 UTC
Permalink
Post by Marcin Niestroj
Using default value (console) works well, so there is no reason to set
tty explicitly. Additionally after selecting newer kernels (tested
with 4.19 and 4.20-rc3) ttyO0 no longer works due to missing device
node.
Do you know why this is so? Did ttyO0 get renamed?

Committed, thanks.
--
Bye, Peter Korsgaard
Marcin Niestrój
2018-12-10 11:12:28 UTC
Permalink
Post by Peter Korsgaard
Post by Marcin Niestroj
Using default value (console) works well, so there is no reason to set
tty explicitly. Additionally after selecting newer kernels (tested
with 4.19 and 4.20-rc3) ttyO0 no longer works due to missing device
node.
Do you know why this is so? Did ttyO0 get renamed?
I don't know what exactly has changed, as I have not investigated it
deeply. I think that CONFIG_SERIAL_8250_OMAP_TTYO_FIXUP changed the
behavior a little bit, so now there are only ttySx devices, with no
ttyOx anymore. Another possibility is that ttyO0 was created in older
kernel versions, because it was passed by u-boot directly as boot
argument to kernel.
Post by Peter Korsgaard
Committed, thanks.
Thanks!

--
Marcin Niestrój

Loading...